Repository navigation
π fix(ci): retry 'Install just' curl on transient release-CDN errors - #17359
Conversation
Hive-Run: hivecommons#17357 Hive-Plan: issue-17357 Hive-Spec: issue-17357#recommendation Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
There was a problem hiding this comment.
Style review (head 6802932): the change matches #17357's recommendation verbatim at all three sites, and each file's existing indent (10 spaces in v2-ci.yml, 8 in the two integration workflows) is preserved. No blockers.
One advisory, non-blocking:
Step comment in v2-ci.yml no longer explains the retry flags β .github/workflows/v2-ci.yml:1026-1034 justifies the pinned URL with "The releases CDN stayed up throughout; a pinned URL with a checksum has no API dependency at all." The new --retry 5 --retry-delay 10 --retry-all-errors on line 1040 exists precisely because the CDN does fail transiently (504s per #17357), but nothing in the comment says so. A future reader may see the flags as noise and trim them. Suggested one-line addition after line 1034:
# had passed. The releases CDN stayed up throughout; a pinned URL with a
# checksum has no API dependency at all. Bump the version and hash
# together, deliberately. The CDN itself still 504s transiently (#17357),
# hence the curl --retry flags; sha256sum still gates whatever is fetched.
The two integration workflows (integration-candidate.yml:550, integration-technical-v2-ci.yml:404) have no comment block, so nothing to update there.
β hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Needs a decision, not a merge:
Head: verdict requires_human @67bd567, 61/61 checks green, DCO yes, sentinel alert, soak 9m0s of 10m0s. How to release it:
Clear the cause and the hive re-evaluates on its next pass; the stage moves to Updated 2026-11-09 09:43 UTC. |
|
CI triage ( π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
@Karibhou this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
Review follow-up on hivecommons#17359. Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
|
Style review follow-up: added the suggested two-line note to the β hive: backend=omp model=anthropic/claude-opus-5-5 π Hive Agent: |
67bd567
|
There was a problem hiding this comment.
Decision needed: @clubanderson should confirm this workflow-only change (curl --retry flags on the pinned, checksummed Install just download in three workflows) may land; the hive cannot approve a .github/workflows/** edit that carries sentinel-alert.
Routing to a code owner rather than judging alone: this edits .github/workflows/** (CODEOWNERS: @clubanderson @hanthor @Danathar) and carries the sentinel-alert label, so a person has to sign it off.
Facts I verified from the diff against v5:
- The only change on each of the three files is on the
curlline of theInstall juststep:-fsSLgains--retry 5 --retry-delay 10 --retry-all-errors.v2-ci.yml:1041,integration-candidate.yml:555,integration-technical-v2-ci.yml:409. - The URL is still the pinned release tarball for
JUST_VERSION=1.58.0, and thesha256sum -c -line immediately after is unchanged, so a retried fetch that returns the wrong bytes still fails the job. Nopermissions:block, trigger, secret, or step ordering changes. --retry-all-errorsmakes curl retry on HTTP 4xx/5xx as well as transport errors; with-fa persistent 404 would cost ~50s of retries before failing, which is the intended trade for the 504s described in #17357.v2-ci.ymlalso gains a two-line comment pointing at #17357, consistent with the existing comment block above the step.
Nothing in the change looks wrong to me; the decision is a trust-surface sign-off, not a code defect.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
/lgtm Posted by @clubanderson from the Hive dashboard; the merge gate decides from here. |
|
@hivecommons-hive[bot]: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve Posted by @clubanderson from the Hive dashboard; the merge gate decides from here. |
|
@clubanderson approved head |
|
/lgtm Reviewed: |
|
LGTM label has been added. DetailsGit tree hash: f9d18867eb801008f6d097befa6bbc7c8e400ffc |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clubanderson, hivecommons-hive[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
|
@clubanderson: No presubmit jobs available for hivecommons/hive@v5 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
* fix(automerge): post /ok-to-test once on admitted non-member fork PRs On a Prow-managed repository the trigger plugin runs presubmits for a non-member's fork PR only after a trusted user comments /ok-to-test, so an admitted contributor-lane PR (#17359) sat green on GitHub Actions while Tide reported "Jobs ... have not succeeded". While such a fork head is not green, the contributor lane now posts /ok-to-test once per head through the existing mutation boundary and per-head marker (postWorkflowApprovalCommand) when the repo is Prow-managed (hgithub.ProwManagedLabels, now exported, or Prow's [APPROVALNOTIFIER] comment), the author is not OWNER/MEMBER/COLLABORATOR, the PR has no ok-to-test label and Prow reported no presubmit status on the head. A Prow "Cannot trigger testing until a trusted user" reply is recorded once (skipped=prow-rejects-bot-commands), leaves one needs-human note and stops every later post on the PR. The relay's read-only evaluation posts nothing. Fixes #17474 Hive-Run: #17474 Hive-Plan: #17451 child 1 (prow /ok-to-test on fork PRs) Hive-Spec: #17474#scope Signed-off-by: Karibhou <Karibhou@users.noreply.github.com> * π fix(automerge): rename ok-to-test source so Go builds it outside tests automerge_contributor_prow_ok_to_test.go ended in _test.go, so Go compiled it only into the test binary and the non-test build failed with requestProwPresubmitsForFork undefined. Hive-Run: #17474 Hive-Plan: #17451 child 1 (prow /ok-to-test on fork PRs) Hive-Spec: #17474#scope Signed-off-by: Karibhou <Karibhou@users.noreply.github.com> --------- Signed-off-by: Karibhou <Karibhou@users.noreply.github.com> Co-authored-by: Karibhou <Karibhou@users.noreply.github.com> Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Adds
--retry 5 --retry-delay 10 --retry-all-errorsto theInstall justcurl inv2-ci.yml,integration-candidate.yml, andintegration-technical-v2-ci.yml. Thesha256sum -ccheck is unchanged, so integrity is still verified.Fixes #17357
β hive: backend=omp model=anthropic/claude-opus-5-5
π Hive Agent:
contributor| SHA:6802932f8